Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psalm v6: strict_types=1 #10044

Merged
merged 51 commits into from
Oct 21, 2023
Merged

Psalm v6: strict_types=1 #10044

merged 51 commits into from
Oct 21, 2023

Conversation

danog
Copy link
Collaborator

@danog danog commented Jul 24, 2023

Enables strict types and converts all typehints to native typehints.

@danog danog added the release:internal The PR will be included in 'Internal changes' section of the release notes label Jul 24, 2023
@weirdan
Copy link
Collaborator

weirdan commented Jul 24, 2023

BCC failures need to go to UPGRADING.md

@danog danog added this to the Psalm 6 milestone Jul 25, 2023
@danog
Copy link
Collaborator Author

danog commented Jul 26, 2023

I've added BCC notes for the amp breaking changes, the rest is all stuff that would have been detected by Psalm anyway, so just added a single line for that.

@danog danog marked this pull request as ready for review October 19, 2023 11:55
@danog
Copy link
Collaborator Author

danog commented Oct 19, 2023

Should be good to merge @orklah @weirdan! :)

@danog danog requested a review from orklah October 19, 2023 11:55
@orklah
Copy link
Collaborator

orklah commented Oct 21, 2023

Thanks!

@orklah orklah merged commit 75fcfe3 into vimeo:master Oct 21, 2023
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants